Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): fallback to github & unpkg to get README.md #16322

Merged
merged 5 commits into from
Aug 5, 2019
Merged

fix(www): fallback to github & unpkg to get README.md #16322

merged 5 commits into from
Aug 5, 2019

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Aug 2, 2019 •
edited
Loading

Description

Fixes empty readme files.

This is the debug log when falling back to github & unpkg

readme created from github for gatsby-plugin-metomic
readme created from github for gatsby-transformer-sqip
readme created from github for gatsby-source-prismic
readme created from github for gatsby-plugin-sharp
readme created from github for gatsby-source-graphql
readme created from github for @hakrsingh/gatsby-theme-chaos
readme created from github for gatsby-plugin-algolia-docusearch
readme created from github for @monastic.panic/gatsby-transformer-react-docgen
readme created from github for gatsby-transformer-video
readme created from github for gatsby-source-prismic-graphql
readme created from github for @wonism/gatsby-source-wordpress
readme created from unpkg for gatsby-plugin-freshdesk
readme created from unpkg for gatsby-plugin-mdx-prismjs
readme created from unpkg for @nteract/gatsby-transformer-ipynb
readme created from unpkg for gatsby-plugin-google-adsense
readme created from unpkg for gatsby-plugin-eslint-v2
readme created from unpkg for gatsby-plugin-react-next
readme created from unpkg for @wardpeet/gatsby-plugin-static-site

It's based on @Haroenv comment

Related Issues

Fixes #16318
Fixes #11129

@wardpeet wardpeet requested a review from a team as a code owner August 2, 2019 07:54
m-allanson
m-allanson reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question on awaiting the map() call.

packages/gatsby-source-npm-package-search/src/gatsby-node.js Outdated Show resolved Hide resolved
sidharthachatterjee
sidharthachatterjee approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 5, 2019
@gatsbybot gatsbybot merged commit f38b40d into gatsbyjs:master Aug 5, 2019
@Haroenv
Copy link
Contributor

Haroenv commented Aug 5, 2019

nice way of handling with the fallbacks. I still want to get rid of this necessity at some point, but it seemed to be unfixable on npm's side

lipis added a commit to lipis/gatsby that referenced this pull request Aug 5, 2019
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into prettier
1f25f34 
* 'master' of github.com:gatsbyjs/gatsby: (103 commits)
  chore(showcase): add AntdSite (gatsbyjs#16376)
  docs: Fix typos in docs/blog (gatsbyjs#16366)
  chore(starters): add gatsby-starter-fashion-portfolio (gatsbyjs#16333)
  chore(showcase): Add Fourpost (gatsbyjs#16390)
  Docs: Fix a markdown syntax error in recipes.md (gatsbyjs#16371)
  docs: Update building-a-theme.md (gatsbyjs#16364)
  fix: update dependency @theme-ui/prism to ^0.2.29 (gatsbyjs#16385)
  chore: update dependency gatsby to ^2.13.51 (gatsbyjs#16375)
  Fix www build
  fix: update dependency @theme-ui/typography to ^0.2.29 (gatsbyjs#16386)
  fix: update dependency gatsby-plugin-theme-ui to ^0.2.29 (gatsbyjs#16387)
  fix: update dependency theme-ui to ^0.2.29 (gatsbyjs#16388)
  fix(www): fallback to github & unpkg to get README.md (gatsbyjs#16322)
  fix(www): replace \n into newlines for guess (gatsbyjs#16382)
  fix(gatsby): always use publicLoader for window.___loader (gatsbyjs#16122)
  feat(docs): Document what breaking changes are for themes (gatsbyjs#16302)
  docs: Link mapping to @link (gatsbyjs#16152)
  fix(gatsby): Add findMatchPath to the default loader (gatsbyjs#16334)
  feat(gatsby): Allow custom resolver context (gatsbyjs#16359)
  feat(docs): Add docs for @nodeInterface extension (gatsbyjs#16356)
  ...
@m-allanson m-allanson mentioned this pull request Aug 9, 2019
Closed
@iamdarshshah iamdarshshah mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson left review comments

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatsby Plugins Library broken with gatsby themes [www] Empty pages on plugin pages
5 participants
@wardpeet @Haroenv @m-allanson @sidharthachatterjee @gatsbybot