(feat)gatsby-remark-copy-linked-files: create hashLength option to specify the digest hash length

[kimbaudi]

Description

This PR adds a new option called hashLength that would allow users to specify the length of contentDigest

{
  resolve: `gatsby-remark-copy-linked-files`,
  options: {
      hashLength: 9
  },
},

Related Issues

[kimbaudi]

I am new to Jest and unit testing. I am having trouble testing with actual fs-extra functionality (i.e. existsSync, copy, and ensureDir) instead of mocked ones. Currently, the unit tests expects undefined values:

expect(imageURL(markdownAST)).toEqual(`/undefined/undefined.gif`)

In order to test this new hashLength option, I would have to be able to test it using an actual file. Does anybody know if this is possible with Jest? I'll start looking into it, but I am unsure. Maybe this type of test requires end-to-end testing with Cypress instead of Jest? If anyone can point me in the right direction, that would be really helpful.

[sidharthachatterjee]

I would be wary of adding this because if I understand correctly, it strips off characters off the contentDigest from a Node.

If a user needs to set a specific length, they can set the Node's contentDigest appropriately.

And they can pass in a format without it too. This seems fairly niche and I'm not sure if adding another config option is worth the small benefit here.

Based on the above, I'd prefer to close this and not add this option. What do you think @kimbaudi?

[sidharthachatterjee]

@pieh Thoughts?

[pieh]

Why do you need that option? I can't really think of situation when I would want/need to mess with contentDigest?

[kimbaudi]

personally, its fine to close this. I really don't need it. I think I misread something about long filename due to hashing from #10048. I will close this.

[sidharthachatterjee]

Thanks @kimbaudi 👍