chore(gatsby): Unpin @reach/router version with latest release

[blainekasten]

Description

@reach/router published a 1.3.1 fixing the issue that was causing gatsby sites to not navigate correctly. This updates and unpin's the version. I've tested this manually and am hoping that our automated tests will catch anything else.

[sidharthachatterjee]

Woah that was quick!

Thanks @blainekasten 🙌

[sidharthachatterjee]

Looks like snapshots are failing because the role=\"group\" is gone. @madalynrose should be able to add more context of if that's a good thing or bad!

Tests are failing

[blainekasten]

Related commit and change: reach/router@edea55d#diff-e7c4a8f76dc66da880856189f69b846cR22

Would love to understand more about this.. Feels like it might be the wrong approach

[trevorblades]

@blainekasten I just pushed a commit that removes role=\\"group\\" from the failing snapshots. This should make sense since the new version of @reach/router doesn't add this tag any more.

[trevorblades]

Now the e2e test for the development runtime is failing with Error: Cannot find module 'isomorphic-fetch'. I suspect this is unrelated to this change since @reach/router doesn't use this module, however I don't see other PRs failing with this error. I'll do some more digging later.

This seems to be related to isomorphic-fetch being removed from the lockfile. @reach/router upgraded create-react-context to 0.3.0, which removes the fbjs dependency, which in turn had a dependency on isomorphic-fetch.

There was an e2e test that imported isomorphic-fetch but it never explicitly defined the module as a dependency, but since it was a distant dependency of @reach/router<1.3.1 the test worked anyway. 70897ae adds isomorphic-fetch as a dependency in that test's package.json, hopefully addressing the issue!

[trevorblades]

Everything is passing now, but the Gatsby Build step has been in progress for the last >1 hour. Is this typical? @gatsbyjs/core

[sidharthachatterjee]

This makes sense! Thanks @trevorblades and @blainekasten 🥇