Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blog): Gatsby Gazette: The 2019 Recap #21547

Merged
merged 7 commits into from
Feb 18, 2020
Merged

docs(blog): Gatsby Gazette: The 2019 Recap #21547

merged 7 commits into from
Feb 18, 2020

Conversation

sidharthachatterjee
Copy link
Contributor

No description provided.

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner February 18, 2020 08:45
@sidharthachatterjee sidharthachatterjee requested a review from a team February 18, 2020 08:46
@calcsam
Copy link
Contributor

calcsam commented Feb 18, 2020

This is awesome @sidharthachatterjee -- glad you wrote this!!!

LekoArts
LekoArts reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments!

docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
@sidharthachatterjee @calcsam @LekoArts
Apply suggestions from code review
b072c01 
Co-Authored-By: Sam Bhagwat <calcsam@gmail.com>
Co-Authored-By: Lennart <lekoarts@gmail.com>
@sidharthachatterjee sidharthachatterjee changed the title blog: Gatsby Gazette: The 2019 Recap docs(blog): Gatsby Gazette: The 2019 Recap Feb 18, 2020
@sidharthachatterjee sidharthachatterjee added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: blogpost labels Feb 18, 2020
pvdz
pvdz previously approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore my comments, or to merge with my implied blessing if you don't :)

docs/blog/2020-02-18-gazette-2019-recap/index.md Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
laurieontech
laurieontech reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Sid. Updated stuff to use relative paths inside .org. But think it's ready beyond that!

docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
docs/blog/2020-02-18-gazette-2019-recap/index.md Outdated Show resolved Hide resolved
@sidharthachatterjee @laurieontech
Apply suggestions from Laurie
fe7b4e7 
Co-Authored-By: LB <barth.laurie@gmail.com>
laurieontech
laurieontech approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is such a fun way to celebrate the team :)

@gatsbybot gatsbybot merged commit 93b7a21 into master Feb 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the gazette-2019 branch February 18, 2020 14:42
jlkiri pushed a commit to jlkiri/gatsby that referenced this pull request Feb 23, 2020
@sidharthachatterjee @calcsam @LekoArts
docs(blog): Gatsby Gazette: The 2019 Recap (gatsbyjs#21547)
8fc95dc 
* Write the Gazette

* Apply suggestions from code review

Co-Authored-By: Sam Bhagwat <calcsam@gmail.com>
Co-Authored-By: Lennart <lekoarts@gmail.com>

* Polish

* Footer looks weird

* Add more links

* Fix for comments from Pete

* Apply suggestions from Laurie

Co-Authored-By: LB <barth.laurie@gmail.com>

Co-authored-by: Sam Bhagwat <calcsam@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: LB <laurie@gatsbyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcsam calcsam calcsam left review comments

@LekoArts LekoArts LekoArts left review comments

@laurieontech laurieontech laurieontech approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sidharthachatterjee @calcsam @pvdz @laurieontech @LekoArts @gatsbybot