Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-emotion): add @babel/core as peer dependency for pnp #21848

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

Js-Brecht
Copy link
Contributor

Description

This is for yarn-pnp compatibility. Without @babel/core listed as a peer dependency, yarn will be unable to build.

Related Issues

No related issues, as of right now.

* This is for yarn-pnp (yarn2) compatibility
@Js-Brecht Js-Brecht requested a review from a team as a code owner February 28, 2020 22:25
@wardpeet wardpeet changed the title [gatsby-plugin-emotion] Include @babel/core as peer dependency chore(gatsby-plugin-emotion): add @babel/core as peer dependency for pnpm Feb 29, 2020
@wardpeet wardpeet changed the title chore(gatsby-plugin-emotion): add @babel/core as peer dependency for pnpm chore(gatsby-plugin-emotion): add @babel/core as peer dependency for pnp Feb 29, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@wardpeet wardpeet merged commit e72a483 into gatsbyjs:master Feb 29, 2020
@wardpeet
Copy link
Contributor

wardpeet commented Mar 2, 2020

Fixed in gatsby-plugin-emotion@4.1.23

@Js-Brecht Js-Brecht deleted the pnp-compatibility branch March 4, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants