Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gatsby): Extract waitUntilAllJobsComplete out of build and develop command #22059

Merged
merged 2 commits into from
Mar 11, 2020
Merged

refactor(gatsby): Extract waitUntilAllJobsComplete out of build and develop command #22059

merged 2 commits into from
Mar 11, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

Description

Extract duplicate waitUntilAllJobsComplete function out of build & develop command

@MichaelDeBoey MichaelDeBoey requested a review from a team as a code owner March 8, 2020 02:34
@MichaelDeBoey MichaelDeBoey force-pushed the extract-waitUntilAllJobsComplete-out-of-build-and-develop-command branch from d04f594 to 4d9d0f4 Compare March 8, 2020 02:35
wardpeet
wardpeet reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting! 👍 Can you move it outside of commands into utils? It doesn't make much sense for a command.

wardpeet
wardpeet reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting! 👍 Can you move it outside of commands into utils? It doesn't make much sense for a command.

@MichaelDeBoey MichaelDeBoey force-pushed the extract-waitUntilAllJobsComplete-out-of-build-and-develop-command branch from 4d9d0f4 to 85187a2 Compare March 10, 2020 18:49
sidharthachatterjee
sidharthachatterjee approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Michael!

@sidharthachatterjee sidharthachatterjee merged commit cd24d34 into gatsbyjs:master Mar 11, 2020
@MichaelDeBoey
Copy link
Contributor Author

Always a pleasure to help out! 🙂

@MichaelDeBoey MichaelDeBoey deleted the extract-waitUntilAllJobsComplete-out-of-build-and-develop-command branch March 11, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @wardpeet @sidharthachatterjee