chore(gatsby): migrate run-sift to TS #25055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: TypeScript migration
and removed
status: triage needed
ascorbic
reviewed
Jun 17, 2020
| @@ -50,7 +50,7 @@ export function createDbQueriesFromObject(filter: object): Array<DbQuery> { | |||
| } | |||
|
|
|||
| function createDbQueriesFromObjectNested( | |||
| filter: object, | |||
| filter: Record<string, any>, | |||
There was a problem hiding this comment.
Can this be Record<string, unknown>
There was a problem hiding this comment.
Changing the any to unknown triggers cascading errors. Are you sure that's the right way?
There was a problem hiding this comment.
May be related to this:
packages/gatsby/src/db/common/query.ts:63:57 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Record<string, unknown>'.
I hate that my editor throws different errors from yarn typecheck from whatever yarn format does. There should be one state :/
|
Typing fixed, tests are still broken. |
This change is broken because references are not updated. Separate commit for your reviewing pleasure. (The PR will squash it and github will still screw up the rename but at least review is good.)
While trying to be type correct, coercing the value to string has the unintended side effect of allowing regexes (or any other type) as $regex arg. So instead now throwing an explciit error for that case. Also reverted the type where it returns an Array. Apparently there are cases where it is not an array.
|
Ok. Tests should pass now. Typings were cleaned up. I thought runFastFilters would accept an array of filters to apply. But apparently, and through the magic of lodash, that's not exactly the case. So I reverted annotating those input/output types as arrays. Also removed a String case that was accidentally allowing types that shouldn't be allowed. Good thing we have tests :) |
pvdz
added
the
status: needs core review
blainekasten
approved these changes
Jun 17, 2020
axe312ger
pushed a commit
that referenced
this pull request
Jun 23, 2020
* Rename file to .ts and drop the sift name This change is broken because references are not updated. Separate commit for your reviewing pleasure. (The PR will squash it and github will still screw up the rename but at least review is good.) * Convert run-fast-filters (run-sift) to TS * Applied suggestions * Remove more unknowns * wip * Fix regression While trying to be type correct, coercing the value to string has the unintended side effect of allowing regexes (or any other type) as $regex arg. So instead now throwing an explciit error for that case. Also reverted the type where it returns an Array. Apparently there are cases where it is not an array.
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* Rename file to .ts and drop the sift name This change is broken because references are not updated. Separate commit for your reviewing pleasure. (The PR will squash it and github will still screw up the rename but at least review is good.) * Convert run-fast-filters (run-sift) to TS * Applied suggestions * Remove more unknowns * wip * Fix regression While trying to be type correct, coercing the value to string has the unintended side effect of allowing regexes (or any other type) as $regex arg. So instead now throwing an explciit error for that case. Also reverted the type where it returns an Array. Apparently there are cases where it is not an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts run-sift to TS and removes "sift" from the file name.