Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unlinked reference doc for new file system based route APIs #26222

Merged
merged 11 commits into from
Aug 10, 2020

Conversation

blainekasten
Copy link
Contributor

Description

We are going to be shipping #25204 soon behind a feature flag for a few weeks. When we promote it on social media, we want to link a reference document for users to see how to use the API. This is that doc, it's intentionally not linked to anything, and it's not necessarily meant to be a long term doc (though it could be a starting point for more things later).

Related Issues

#25204

@blainekasten blainekasten requested a review from a team as a code owner August 4, 2020 14:27
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 4, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 4, 2020

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 27s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Aug 4, 2020

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 4, 2020

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 25s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 4, 2020

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 25s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 4, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 37m

@AishaBlake AishaBlake added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 4, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blainekasten I've made some edits and renamed the guide to bring this doc more in line with the style guide (see the most recent commit) but I already see that I missed a couple of "we"s in there. In addition, I moved any file names associated with code blocks up into the code title div. I reworded a few things for increased clarity.

Thanks for your patience! Let me know your thoughts on this? I'll keep an eye out so that we can get this in ASAP.

docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
- `/src/pages/products/[...splat].js => /users/*splat`
- `/src/pages/app/[...].js => /app/*`

The dynamic segment of the file name (the part between the square brackets) will be filled in and provided to your components on a `props.params` object. For example:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand a little bit on the syntax here and lay out what ... and * are for in this context? I'm guessing not everyone who wants to use this will be familiar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it, wanna check it out?

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Aug 5, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18m

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 76

🔗 View full report

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking super close to ready! Just a few more suggestions. Let me know what you think? If you're okay with these, feel free to merge!

docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
docs/docs/file-system-page-creation.md Outdated Show resolved Hide resolved
blainekasten and others added 5 commits August 9, 2020 21:06
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
@blainekasten blainekasten dismissed AishaBlake’s stale review August 10, 2020 02:08

This all looks wonderful! You are so good Aisha!

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Thanks for rolling with me, Blaine!

@AishaBlake AishaBlake merged commit 5782bfe into master Aug 10, 2020
@blainekasten blainekasten deleted the docs/fs-routing-reference-doc branch August 10, 2020 15:16
Comment on lines +24 to +25
- `/src/pages/image/[...awsKey].js => /users/*awsKey`
- `/src/pages/image/[...].js => /app/*`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the right side doesn't match left side here - on the left /images/splat - on the right /users/splat or /app/splat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants