-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create unlinked reference doc for new file system based route APIs #26222
Conversation
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 27s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 25s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 25s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 37m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blainekasten I've made some edits and renamed the guide to bring this doc more in line with the style guide (see the most recent commit) but I already see that I missed a couple of "we"s in there. In addition, I moved any file names associated with code blocks up into the code title div. I reworded a few things for increased clarity.
Thanks for your patience! Let me know your thoughts on this? I'll keep an eye out so that we can get this in ASAP.
- `/src/pages/products/[...splat].js => /users/*splat` | ||
- `/src/pages/app/[...].js => /app/*` | ||
|
||
The dynamic segment of the file name (the part between the square brackets) will be filled in and provided to your components on a `props.params` object. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand a little bit on the syntax here and lay out what ...
and *
are for in this context? I'm guessing not everyone who wants to use this will be familiar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated it, wanna check it out?
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18m PerformanceLighthouse report
|
298ad23
to
26189d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking super close to ready! Just a few more suggestions. Let me know what you think? If you're okay with these, feel free to merge!
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Muescha <184316+muescha@users.noreply.github.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
This all looks wonderful! You are so good Aisha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! Thanks for rolling with me, Blaine!
- `/src/pages/image/[...awsKey].js => /users/*awsKey` | ||
- `/src/pages/image/[...].js => /app/*` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the right side doesn't match left side here - on the left /images/splat
- on the right /users/splat
or /app/splat
Description
We are going to be shipping #25204 soon behind a feature flag for a few weeks. When we promote it on social media, we want to link a reference document for users to see how to use the API. This is that doc, it's intentionally not linked to anything, and it's not necessarily meant to be a long term doc (though it could be a starting point for more things later).
Related Issues
#25204