Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update example versions to next #27967

Merged
merged 1 commit into from
Nov 12, 2020
Merged

chore: Update example versions to next #27967

merged 1 commit into from
Nov 12, 2020

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Nov 11, 2020

Description

This PR does multiple things (as I went through every example anyways, so why not take the extra 10sec to clean up a bit):

  1. Update every gatsby-* plugin we own to next version
  2. Remove every .eslintrc.json from example as that is handled in the root of the repo
  3. Remove every LICENSE as this exists in the root of the repo
  4. Remove every .gitignore that only had contents like public, node_modules or .cache as that is handled in the root of the repo
  5. Remove the no-plugins example as it was outdated and our hello-world starter also showcases that
  6. Remove using-cxs example as that project itself is abandoned

[ch18779]

@LekoArts LekoArts requested review from a team as code owners November 11, 2020 10:54
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 11, 2020
@LekoArts LekoArts added type: chore type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: chore labels Nov 11, 2020
@LekoArts LekoArts changed the title update example versions chore: Update example versions Nov 11, 2020
@LekoArts LekoArts changed the title chore: Update example versions chore: Update example versions to next Nov 11, 2020
@wardpeet
Copy link
Contributor

@LekoArts could you keep gitignore file. I copy those files from time to time to a separate git project to work with it.

@LekoArts
Copy link
Contributor Author

@wardpeet But then the examples are not coherent in itself. I didn't remove them from every example as only a couple of those had them. So either every example should have one or none IMO.

@wardpeet
Copy link
Contributor

I was under the impression that every one had it :) Good point! Let's get this in

@wardpeet wardpeet merged commit c7af18d into master Nov 12, 2020
@wardpeet wardpeet deleted the update-examples branch November 12, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants