fix(gatsby-remark-images): support resolving markdown images from child nodes #28093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: remark/mdx
|
any chance to get this reviewed? |
|
still waiting for feedback |
|
rebased on current master, hoping that the patch builds through now |
|
@KyleAMathews I am not sure what to do, the build-test failures do not appear to be related to my changes |
|
Anyone home? |
…ld nodes - in case where remark nodes are created from other nodes (e.g. gatsby-plugin-json-remark) the parent node of a remark document is not a file. - in order to resolve the images still, it is necessary to go up the parent chain until the closest File node
Closed
2 tasks
|
Tested the PR against @rburgst's reproduction and the image is now processed correctly:
So this looks ready to go in assuming tests pass now with updated snapshots. |
|
Thanks again @rburgst for this PR and I'm very sorry it's taken so long to get merged. |
imjoshin
previously approved these changes
May 2, 2022
|
Failing tests were unrelated, merged! Thanks again! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. gatsby-plugin-json-remark) the parent node
of a remark document is not a file.
to go up the parent chain until the closest File node
Fixes #28094