feature(gatsby): Extract non-css-in-js css and add add to <head> when SSRing in dev #28471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowing down regular develop-js HMR
…R + remove activity timers as not helpful
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: feature or enhancement
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid FOUC when a site uses regular CSS. CSS-in-JS already adds its css during dev ssr.
We remove
style-loaderand just use mini-css-extract-plugin withhmrenabled. Beyond making dev-ssr work as expected — it also solves a persistent problem people have with their styles behaving different in production vs development. The current dev styles setup often loads css in a different order depending on what page you visit or the order that you edit files, etc. Moving to mini-css-extract-plugin means that styles are extracted and loaded the same way in dev & production.The main downside I could see to this approach is the mini-css-extract-plugin says style-loader is faster at HMR. This is true but the times seem comparable & acceptable still.
I added tailwind to the ssr integration test as it adds ~210kb of css so to simulate a larger amount of css. With this setup, HMR times increase from ~250ms w/ style-loader to ~330ms w/ mini-css-extract-plugin or a ~35% increase.
I copied in as well a large chunk of css off a site found on the interwebs and compilation jumped to 2050ms for style-loader and 2500ms for mini-css-extract-plugin for a 22.5% increase.
The compilation decrease seems ok given it's still fast & it unblocks dev-ssr & we're removing confusing differences between prod & dev environments.