Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsyb-source-contentful): move locale filter #28553

Merged
merged 3 commits into from
Dec 10, 2020
Merged

chore(gatsyb-source-contentful): move locale filter #28553

merged 3 commits into from
Dec 10, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Dec 9, 2020

Move the plugin option driven locale filter to be after the fetching part rather than inside it. This way GATSBY_CONTENTFUL_EXPERIMENTAL_FORCE_CACHE can still make use of the filter and I can't see a downside of this action.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 9, 2020
@pvdz pvdz added topic: source-contentful Related to Gatsby's integration with Contentful type: chore and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 9, 2020
@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 10, 2020
vladar
vladar approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick check for usages and we should be good with this change. Thanks! 👍

@gatsbybot gatsbybot merged commit 4277b3d into master Dec 10, 2020
@gatsbybot gatsbybot deleted the contentlocaleafter branch December 10, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdz @vladar @gatsbybot