Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sharp) wrap sharp calls in try/catch to avoid crashing on bad images #28645

Merged
merged 2 commits into from
Jan 14, 2021
Merged

fix(sharp) wrap sharp calls in try/catch to avoid crashing on bad images #28645

merged 2 commits into from
Jan 14, 2021

Conversation

nategiraudeau
Copy link
Contributor

@nategiraudeau nategiraudeau commented Dec 15, 2020 •
edited
Loading

Description

Adds try/catch blocks where gatsby-plugin-sharp reads and writes images.

Documentation

gatsby-plugin-sharp documentation.

Related Issues

Fixes #28640

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2020
@nategiraudeau nategiraudeau marked this pull request as ready for review December 16, 2020 01:33
@LekoArts LekoArts added topic: sharp and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 17, 2020
@nategiraudeau nategiraudeau mentioned this pull request Dec 24, 2020
Closed
KyleAMathews
KyleAMathews approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@KyleAMathews KyleAMathews merged commit 004acf0 into gatsbyjs:master Jan 14, 2021
@KyleAMathews KyleAMathews added this to To cherry-pick in V2 Release hotfixes via automation Jan 14, 2021
@gatsbybot gatsbybot mentioned this pull request Jan 16, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 16, 2021
@nategiraudeau @vladar
fix(sharp) wrap sharp calls in try/catch to avoid crashing on bad ima…
8fe7b3e 
…ges (#28645)

* added try/catch blocks around image processing

* fixed return on getImageMetadata

(cherry picked from commit 004acf0)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Jan 16, 2021
gatsbybot pushed a commit that referenced this pull request Jan 16, 2021
@nategiraudeau
fix(sharp) wrap sharp calls in try/catch to avoid crashing on bad ima…
bd5c63c 
…ges (#28645) (#29052)

* added try/catch blocks around image processing

* fixed return on getImageMetadata

(cherry picked from commit 004acf0)

Co-authored-by: Nate Giraudeau <50968964+nategiraudeau@users.noreply.github.com>
@vladar
Copy link
Contributor

vladar commented Jan 16, 2021

Published in gatsby-plugin-sharp@2.12.2

@vladar vladar moved this from Backport PR opened to Backported in V2 Release hotfixes Jan 16, 2021
This was referenced Jan 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 1, 2024
Open
Open
This was referenced Jan 1, 2024
Open
Open
Open
@wizbit wizbit mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 15, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
This was referenced Mar 15, 2024
Open
Open
Open
@monizb monizb mentioned this pull request Mar 16, 2024
Open
This was referenced Mar 16, 2024
Open
Open
Open
@joeawillis joeawillis mentioned this pull request Mar 16, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 16, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 18, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
V2 Release hotfixes
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap sharp calls in try/catch to avoid crashing on bad images
4 participants
@nategiraudeau @vladar @KyleAMathews @LekoArts