chore(telemetry) improve github action and circle detection #28732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: telemetry*
and removed
status: triage needed
pieh
reviewed
Dec 22, 2020
Comment on lines
+11
to
+12
| getEnvDetect({ key: `CIRCLE_BRANCH`, name: `CircleCI` }), | ||
| getEnvDetect({ key: `CIRCLECI`, name: `CircleCI` }), |
There was a problem hiding this comment.
Just for papertrail - CircleCi env vars are document in https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables (at least as of moment of writing this comment heh)
pieh
reviewed
Dec 22, 2020
| getEnvDetect({ key: `NOW_BUILDER_ANNOTATE`, name: `ZEIT Now` }), | ||
| getEnvDetect({ key: `NOW_REGION`, name: `ZEIT Now v1` }), | ||
| getEnvDetect({ key: `VERCEL_URL`, name: `Vercel Now` }), | ||
| getEnvDetect({ key: `NOW_BUILDER`, name: `Vercel Now` }), | ||
| getEnvDetect({ key: `VERCEL_BUILDER`, name: `Vercel Now` }), | ||
| getEnvDetect({ key: `CODESANDBOX_SSE`, name: `CodeSandbox` }), | ||
| getEnvDetect({ key: `GITHUB_ACTIONS`, name: `GitHub Actions` }), |
There was a problem hiding this comment.
Documented in https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables (at least as of moment of writing this comment)
vladar
pushed a commit
that referenced
this pull request
Dec 23, 2020
* chore(telemetry) improve github action and circle detection * Change order * Make sure tests work in circle (cherry picked from commit 3af7182)
vladar
pushed a commit
that referenced
this pull request
Dec 23, 2020
|
Published in |
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
ENVbased CI detection. This would be cool to backport