Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Partially release develop SSR to 5% #28844

Merged
merged 2 commits into from
Jan 5, 2021
Merged

feat(gatsby): Partially release develop SSR to 5% #28844

merged 2 commits into from
Jan 5, 2021

Conversation

KyleAMathews
Copy link
Contributor

For the 2.30 release

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 4, 2021
pieh
pieh requested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor linting related change needed

Other than that this LGTM

packages/gatsby/src/services/initialize.ts Show resolved Hide resolved
@pieh pieh added topic: ssr and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 4, 2021
@pieh pieh merged commit 6b8cd5d into master Jan 5, 2021
@pieh pieh deleted the ssr-rollout branch January 5, 2021 11:17
@gatsbybot gatsbybot mentioned this pull request Jan 5, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 5, 2021
@KyleAMathews @vladar
feat(gatsby): Partially release develop SSR to 5% (#28844)
2cc4afb 
* feat(gatsby): Partially release develop SSR to 5%

* Fix typescript lint

(cherry picked from commit 6b8cd5d)
gatsbybot pushed a commit that referenced this pull request Jan 5, 2021
@KyleAMathews
feat(gatsby): Partially release develop SSR to 5% (#28844) (#28859)
f04304e 
* feat(gatsby): Partially release develop SSR to 5%

* Fix typescript lint

(cherry picked from commit 6b8cd5d)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label May 28, 2021
@saurabharch saurabharch mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 4, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
@0xSebin 0xSebin mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 6, 2022
Open
@saurabharch saurabharch mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 25, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
This was referenced Dec 25, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 26, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 27, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 21, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jun 21, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleAMathews @pieh @LekoArts