Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify html.js vs. onPreRenderHTML #34203

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Clarify html.js vs. onPreRenderHTML #34203

merged 2 commits into from
Dec 6, 2021

Conversation

graysonhicks
Copy link
Contributor

Clarify a note that adding a script via html.js is the same as using onPreRenderHTML.

Description

Documentation

Related Issues

@graysonhicks
Clarify html.js vs. onPreRenderHTML
d80ede5 
Clarify a note that adding a script via html.js is the same as using onPreRenderHTML.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 6, 2021
KyleAMathews
KyleAMathews previously approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KyleAMathews KyleAMathews added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 6, 2021
@gatsbybot gatsbybot merged commit c85a707 into master Dec 6, 2021
@gatsbybot gatsbybot deleted the clarify-htmljs-and-onprerenderhtml branch December 6, 2021 15:33
@kaocher82 kaocher82 mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graysonhicks @KyleAMathews @gatsbybot