Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix links to shared layout component #34330

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

seanparmelee
Copy link
Contributor

Description

I was reading https://www.gatsbyjs.com/docs/recipes/styling-css/#using-global-styles-in-a-layout-component and noticed the "shared layout component" link is linking to a fragment that doesn't exist. I believe the intention was for the link to point to https://www.gatsbyjs.com/docs/tutorial/part-2/#create-a-reusable-layout-component so this PR updates that link as well as a couple others that were pointing to the same missing hash.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 28, 2021
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 7578d71 into gatsbyjs:master Jan 3, 2022
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jan 5, 2022
* master: (125 commits)
  chore(release): Publish next
  fix(gatsby): createNode return promise (gatsbyjs#34399)
  chore(release): Publish next
  fix(gatsby): Wrong route resolved by findPageByPath function (gatsbyjs#34070)
  fix(deps): update typescript to v5 (major) (gatsbyjs#33786)
  chore(docs): Update processing external images guide (gatsbyjs#34388)
  chore(deps): update dependency aws-sdk to ^2.1048.0 (gatsbyjs#34365)
  chore(deps): update dependency autoprefixer to ^10.4.1 for gatsby-plugin-sass (gatsbyjs#34357)
  chore(deps): update formatting & linting (gatsbyjs#34370)
  fix(deps): update minor and patch dependencies for gatsby-source-drupal (gatsbyjs#34375)
  fix(deps): update dependency eslint-plugin-react to ^7.28.0 (gatsbyjs#34372)
  fix(deps): update dependency resolve-url-loader to ^3.1.4 for gatsby-plugin-sass (gatsbyjs#34361)
  chore(deps): update dependency typescript to ^4.5.4 (gatsbyjs#34358)
  chore(docs): Fix links to shared layout component (gatsbyjs#34330)
  chore: Fix typo (gatsbyjs#34349)
  chore(examples): use mobx v6 in using-mobx example (gatsbyjs#34351)
  chore(deps): update dependency rewire to v6 for gatsby-plugin-offline (gatsbyjs#34376)
  chore(deps): update dependency msw to ^0.36.3 for gatsby-core-utils (gatsbyjs#34367)
  chore(deps): update dependency msw to ^0.36.3 for gatsby-plugin-gatsby-cloud (gatsbyjs#34368)
  fix(deps): update dependency graphql to ^15.8.0 for gatsby-codemods (gatsbyjs#34373)
  ...
@seanparmelee seanparmelee deleted the docs/fix-layout-links branch February 1, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants