-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(gatsby): Add a memory test suite command to the memory benchmark #34810
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
17b4d3d
Create memory test suite for measuring multiple runs
imjoshin 62416cb
Minor updates
imjoshin cd75fc6
Add inc suite
imjoshin 12ba91b
Increase node's heap limit
imjoshin 539291c
Add memory tracking
imjoshin f28ba4a
Revert "Add memory tracking"
imjoshin 0b93888
Add docker rebuild command
imjoshin cc71c62
Rework what/how results are given
imjoshin f7109ef
Actually use path var
imjoshin 727724f
Merge branch 'master' into j0sh77/memory-test-suite
imjoshin 6cec998
Revert "Revert "Add memory tracking""
imjoshin b08026f
Use faster method for grabbing memory usage
imjoshin b60b4aa
Output fixes
imjoshin f267261
Update output dir and add comments
imjoshin 94e3840
Update readme
imjoshin d2cb896
Update readme again
imjoshin fe382cc
Add ability to conditionally set jemalloc as the memory allocator
imjoshin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
output | ||
.docker.memusage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
while true; do | ||
PROCESS="node" | ||
|
||
# find all node processes | ||
PROCESS_USAGES=$(ps -eo rss,pid,euser,args:100 --sort %mem | grep -v grep | grep -i "${PROCESS}" | awk '{print $1}') | ||
|
||
# sum the usage | ||
SUM_USAGE=$(echo "$PROCESS_USAGES" | awk '{s+=$1} END {printf "%.0f\n", s}') | ||
|
||
# write to file | ||
echo -e "$SUM_USAGE" > /usr/src/app/.docker.memusage | ||
sleep .25 | ||
done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, just future opportunity:
Maybe we can just install
jemalloc
always in image and then have--use-jemalloc
as toggle for cli (we could setLD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so
env var in test runner script to enable it), this could limit how often we have to (re)build image when testingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I think if we revisit this, that's a good improvement.