Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use GCS for pipeline tests #36413

Merged
merged 2 commits into from
Aug 18, 2022
Merged

chore: Use GCS for pipeline tests #36413

merged 2 commits into from
Aug 18, 2022

Conversation

LekoArts
Copy link
Contributor

Description

Unsplash seems to be changing the files and thus failing our tests. So we moved the files to our GCS. I've downloaded the images from those URLs and each ran npx md5-file photoA.jpeg to generate the new hashes for the tests

@LekoArts LekoArts added the topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot label Aug 18, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 18, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 18, 2022
julienp
julienp previously approved these changes Aug 18, 2022
Copy link
Contributor

@julienp julienp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinjude
marvinjude previously approved these changes Aug 18, 2022
pieh
pieh previously approved these changes Aug 18, 2022
@LekoArts LekoArts dismissed stale reviews from pieh, marvinjude, and julienp via fd831a4 August 18, 2022 13:47
@LekoArts LekoArts added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 18, 2022
@gatsbybot gatsbybot merged commit dc283d7 into master Aug 18, 2022
@gatsbybot gatsbybot deleted the fix-pipeline-tests-again branch August 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants