fix(gatsby): pass custom graphql context provided by createResolverContext to materialization executor #36552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: GraphQL
pieh
force-pushed
the
fix/resolver-context-materialization
branch
from
22caa9b
to
0fabe76
Compare
…ntext to materialization executor
pieh
force-pushed
the
fix/resolver-context-materialization
branch
from
0fabe76
to
caa3bd2
Compare
pieh
commented
Sep 6, 2022
| @@ -875,6 +885,7 @@ function resolveField( | |||
| schema, | |||
| schemaComposer, | |||
| nodeModel, | |||
| customContext, | |||
There was a problem hiding this comment.
this is main fix - rest is just "prop drilling" to get it here
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 14, 2022
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolver / graphql context that plugins can inject was not available during materialization. This will happen only if the query would sort or filter on fields with custom resolvers that rely on that custom context, so it wasn't failing all the time (just depending on query).
Related Issues
datocms/gatsby-source-datocms#196