[v2] Topics/peer dependencies #3671
Conversation
ghost
assigned 
packages/gatsby-cli/README.md
Outdated
| @@ -10,7 +10,7 @@ package installed locally. | |||
|
|
|||
| ## Install | |||
|
|
|||
| `npm install --global gatsby-cli` | |||
| `npm install --global gatsby-cli react react-dom` | |||
There was a problem hiding this comment.
I don't think that's right. We don't want to install those globally.
There was a problem hiding this comment.
I'm not expert on dependencies but these propably should be added to starters as dependencies but there are so many of those starters and many of them are unofficial so making react and react-dom peer dependencies will break them I think
There was a problem hiding this comment.
I just arrived at the same conclusion 👍
This is coming with a major version bump – I'd be surprised if this is the only thing that breaks compatibility with existing starters, but I don't know
There was a problem hiding this comment.
yeah — we'll upgrade the official starters and perhaps a few others. There'll be an upgrade guide for sites that starters will need to go through. It won't break anything though as a starter with a gatsby@1 dependency will keep working as normal.
|
Yeah, we'll have an upgrade guide which will say to install react/react-dom. Starters won't break because they'll have gatsby v1 in their package.json. But once their maintainers upgrade the starter, they'll add react/react-dom as dependencies so things will work fine. |
per #1990