Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop __renderedByLocation prop when calculating slice props hashes and don't expose it to slice component #36979

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 7, 2022

Description

This is implementation detail we use for better code frames that currently is:
a) exposed to slice template itself (should not be there)
b) can change the props hash when <Slice> placeholder change position in js file and therefore force rebuilds we don't want or need

Documentation

Related Issues

…shes and don't expose it to slice component
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 7, 2022
@pieh pieh added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 7, 2022
@pieh pieh merged commit 2b5af32 into master Nov 7, 2022
@pieh pieh deleted the pieh-patch-2 branch November 7, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants