Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): stale node manifests #36988

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Nov 8, 2022

In some cases it seems there are no pending page data writes but there are still node manifests that should be written out.
I added a stale node manifest check to fix it. Always writing them out is problematic since flush can be called multiple times after node manifests are stored and sometimes there aren't pending writes until the second time it's called. When there are pending writes we want to process the node manifests at the same time as page-data.json files because the node manifest ID is added to page-data.json when they're processed at the same time.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 8, 2022
@TylerBarnes TylerBarnes changed the base branch from master to release/4.24 November 8, 2022 22:01
@TylerBarnes
Copy link
Contributor Author

canary published as gatsby@4.24.8-alpha-stale-node-manifests.1

@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 9, 2022
@TylerBarnes TylerBarnes merged commit 07a126d into release/4.24 Nov 9, 2022
@TylerBarnes TylerBarnes deleted the fix/stale-node-manifests branch November 9, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants