Migrate to React Hot Loader v4 #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Np 😃For the v2 change, should we use the v2 branch? Cause there's a few test failing on the branch and the branch can't be merged. |
|
What v2 change? This PR was to v2 :-) |
|
I mean for the next PR on the v2 😃 |
|
Oh right :-) yeah! Keep them coming! |
m-allanson
added a commit
to m-allanson/gatsby
that referenced
this pull request
Apr 4, 2018
* v2: Docgen improvements (gatsbyjs#4757) adjust createLocation calls after gatsbyjs#4714 (gatsbyjs#4805) Update breaking changes doc use basename for router instead of prefixing in link (gatsbyjs#4714) Fix inlined styles with path-prefixing (gatsbyjs#4717) Publish Upgrade & format [v2][wip] Upgrade Gatsby v2 to webpack 4 (gatsbyjs#4588) fix some jsdoc parsing bits (gatsbyjs#4675) [v2] fix wrong merge Publish Migrate to React Hot Loader v4 (gatsbyjs#4500) [v2] Fix deleteNodes deprecation (gatsbyjs#4453) Publish Switch to latest version of sharp to prevent yarn/npm errors (gatsbyjs#4417) # Conflicts: # packages/gatsby/package.json # packages/gatsby/src/utils/webpack-utils.js # yarn.lock
|
Hiya @noelebrun! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple migration to React Hot Loader v4 done. All in-browser test works fine on my side.
Unit test are not passing. They were already failing on origin/v2 before my changes.
Thanks,
Noé