Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New .org title -- Build blazing fast / modern / beautiful / secure websites with React (slider) #6284

Merged
merged 6 commits into from
Jul 13, 2018

Conversation

calcsam
Copy link
Contributor

@calcsam calcsam commented Jul 3, 2018

Changes the title to "Build blazing fast / modern / beautiful / secure websites with React."

(1) We want to do this to move away from the term "static". It's confusing to people because Gatsby can do way more than people expect from an SSG
(2) Want to highlight the capabilities of Gatsby. It can do so many things so a sliding adjective might highlight that better than just a simple transition => "Build blazing fast websites with React."

Notes and questions:
(1) @fk -- what do you think about drop-in animation vs other types? Eg anything on here: https://codepen.io/amritleone/pen/qERPmW.
(2) By making the rotating world an adjective about website we aren't able to highlight other features of Gatsby. @jlengstorf suggested "Build blazing fast sites / more efficient teams / React + GraphQL apps / modern apps / happier with Gatsby."

We currently treat the homepage as more of a homepage for a docs site, rather than talking about organizational / personal / etc benefits to Gatsby. Open to change this but worth a discussion.
(3) Are there other adjectives we'd want to use in addition to / in place of the ones above?
(4) We probably want to clean this up a bit into its own component but want to get feedback on overall PR first.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 3, 2018

Deploy preview for using-drupal ready!

Built with commit 0625c12

https://deploy-preview-6284--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 3, 2018

Deploy preview for gatsbygram ready!

Built with commit 0625c12

https://deploy-preview-6284--gatsbygram.netlify.com

@m-allanson
Copy link
Contributor

@jlengstorf
Copy link
Contributor

screenshot_20180704-092859

I think the line-height may need adjustment, because the "g" is cut off.

Also, there's a blank cell in the rotation.

Overall, I dig this. I think my preference would be to speed up the transition speed a bit (same pause between transitions) and maybe tighten up the range a bit, like have it travel a shorter distance on the way in and out.

@fk
Copy link
Contributor

fk commented Jul 5, 2018

Niiice!

what do you think about drop-in animation vs other types?

"drop-in" would have been my choice, too, but I also think it's a little to slow: 💯 to everything @jlengstorf said regarding speed and range.

@calcsam
Copy link
Contributor Author

calcsam commented Jul 5, 2018

Thanks @fk and @jlengstorf!

  • Adjusted line-height so that the 'g' is not cut off
  • Sped up transition by 20%
  • Decreased travel distance by 40%
  • Removed empty fifth space

(when it deploys: https://deploy-preview-6284--gatsbyjs.netlify.com/)

@fk -- what's your thought on this orange hex? I used the orange later down on the page as a base and darkened it a bit to match the purple.

@KyleAMathews -- thoughts?

@KyleAMathews
Copy link
Contributor

Like it! Definitely agree it's time to move away from "static" branding Two concerns are a) orange color feels off and b) the spacing is too large between "build" and the different messages.

@jlengstorf
Copy link
Contributor

Looking good, @calcsam!

On small viewports the purple text runs into the purple background, though:

screen shot 2018-07-05 at 2 38 28 pm

Maybe it could shrink a bit on smaller viewports?

Here's a version with font-size: 1.5rem:

screen shot 2018-07-05 at 2 41 03 pm

Here's a version with decreased top padding on the container dropped to 5.5rem:

screen shot 2018-07-05 at 2 42 20 pm

@fk
Copy link
Contributor

fk commented Jul 9, 2018

@jlengstorf Ugh, that $#! skewed background again… :/

Re: orange—maybe try colors.lilac; doesn't stand out as much, but hopefully the animation will take care of that.

@calcsam
Copy link
Contributor Author

calcsam commented Jul 11, 2018

@fk ooh, colors.lilac looks nice! Added.
@jlengstorf I've fixed the text on small resolution screens (works down to 320px and looks reasonable on 310px) by adjusting font size.
@KyleAMathews reduced the too-large spacing.

last question is for @fk -- what's your preference re: the css here? I'm not really a fan of the glamor keyframes syntax which is core to the logic here so would prefer to leave as is -- the Slider component is encapsulated so should be reusable whenever anyone wants it next.

This is ready to merge, so removing [WIP].

@calcsam calcsam changed the title [WIP] demo of new slider frontpage title. New .org title -- Build blazing fast / modern / beautiful / secure websites with React (slider) Jul 11, 2018
@fk
Copy link
Contributor

fk commented Jul 11, 2018

@calcsam

what's your preference re: the css here? I'm not really a fan of the glamor keyframes syntax which is core to the logic here so would prefer to leave as is

No preference—leave it as it is!

jlengstorf
jlengstorf previously approved these changes Jul 11, 2018
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@calcsam
Copy link
Contributor Author

calcsam commented Jul 13, 2018

Going to merge this in! Builds on master are failing but should go live after those are fixed.

@calcsam calcsam merged commit af981fe into master Jul 13, 2018
cassiebeckley pushed a commit to cassiebeckley/gatsby that referenced this pull request Sep 10, 2018
…bsites with React (slider) (gatsbyjs#6284)

* v1 demo

* new version

* fix responsive screen size for 320px, change color to lilac

* encapsulate slider in its own component

* encapsulate color in slider

* remove left-over react-rotating-text reference
fk pushed a commit that referenced this pull request Sep 10, 2018
* Move slider CSS to glamor

* New .org title -- Build blazing fast / modern / beautiful / secure websites with React (slider) (#6284)

* v1 demo

* new version

* fix responsive screen size for 320px, change color to lilac

* encapsulate slider in its own component

* encapsulate color in slider

* remove left-over react-rotating-text reference
@m-allanson m-allanson deleted the change-frontpage-title branch September 27, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants