-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New .org title -- Build blazing fast / modern / beautiful / secure websites with React (slider) #6284
Conversation
Deploy preview for using-drupal ready! Built with commit 0625c12 |
Deploy preview for gatsbygram ready! Built with commit 0625c12 |
Preview link: https://deploy-preview-6284--gatsbyjs.netlify.com/ |
I think the line-height may need adjustment, because the "g" is cut off. Also, there's a blank cell in the rotation. Overall, I dig this. I think my preference would be to speed up the transition speed a bit (same pause between transitions) and maybe tighten up the range a bit, like have it travel a shorter distance on the way in and out. |
Niiice!
"drop-in" would have been my choice, too, but I also think it's a little to slow: 💯 to everything @jlengstorf said regarding speed and range. |
Thanks @fk and @jlengstorf!
(when it deploys: https://deploy-preview-6284--gatsbyjs.netlify.com/) @fk -- what's your thought on this orange hex? I used the orange later down on the page as a base and darkened it a bit to match the purple. @KyleAMathews -- thoughts? |
Like it! Definitely agree it's time to move away from "static" branding Two concerns are a) orange color feels off and b) the spacing is too large between "build" and the different messages. |
Looking good, @calcsam! On small viewports the purple text runs into the purple background, though: Maybe it could shrink a bit on smaller viewports? Here's a version with Here's a version with decreased top padding on the container dropped to |
@jlengstorf Ugh, that $#! skewed background again… :/ Re: orange—maybe try |
@fk ooh, colors.lilac looks nice! Added. last question is for @fk -- what's your preference re: the css here? I'm not really a fan of the glamor keyframes syntax which is core to the logic here so would prefer to leave as is -- the This is ready to merge, so removing [WIP]. |
No preference—leave it as it is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Going to merge this in! Builds on master are failing but should go live after those are fixed. |
…bsites with React (slider) (gatsbyjs#6284) * v1 demo * new version * fix responsive screen size for 320px, change color to lilac * encapsulate slider in its own component * encapsulate color in slider * remove left-over react-rotating-text reference
* Move slider CSS to glamor * New .org title -- Build blazing fast / modern / beautiful / secure websites with React (slider) (#6284) * v1 demo * new version * fix responsive screen size for 320px, change color to lilac * encapsulate slider in its own component * encapsulate color in slider * remove left-over react-rotating-text reference
Changes the title to "Build blazing fast / modern / beautiful / secure websites with React."
(1) We want to do this to move away from the term "static". It's confusing to people because Gatsby can do way more than people expect from an SSG
(2) Want to highlight the capabilities of Gatsby. It can do so many things so a sliding adjective might highlight that better than just a simple transition => "Build blazing fast websites with React."
Notes and questions:
(1) @fk -- what do you think about drop-in animation vs other types? Eg anything on here: https://codepen.io/amritleone/pen/qERPmW.
(2) By making the rotating world an adjective about website we aren't able to highlight other features of Gatsby. @jlengstorf suggested "Build blazing fast sites / more efficient teams / React + GraphQL apps / modern apps / happier with Gatsby."
We currently treat the homepage as more of a homepage for a docs site, rather than talking about organizational / personal / etc benefits to Gatsby. Open to change this but worth a discussion.
(3) Are there other adjectives we'd want to use in addition to / in place of the ones above?
(4) We probably want to clean this up a bit into its own component but want to get feedback on overall PR first.