Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom blocks not using custom classes #6368

Merged

Conversation

giraffesyo
Copy link
Contributor

Fixes #6366

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 10, 2018

Deploy preview for using-drupal ready!

Built with commit a41db82

https://deploy-preview-6368--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 10, 2018

Deploy preview for gatsbygram ready!

Built with commit a41db82

https://deploy-preview-6368--gatsbygram.netlify.com

@m-allanson
Copy link
Contributor

This looks good, thanks @giraffesyo.

What do you think about changing the config format of gatsby-remark-custom-blocks to match the format expected by remark-custom-blocks? Then we can just pass the options straight through, and it won't be a breaking change if this feature wasn't working before.

@giraffesyo
Copy link
Contributor Author

giraffesyo commented Jul 10, 2018

@m-allanson If you pass the options as documented on the remark-custom-blocks repo it works as expected, as I noted in #6366. So, in that case it would just be a documentation change. My question is, was there originally a reason to have a different format from remark-custom-blocks?

@m-allanson
Copy link
Contributor

👍 Yeah let's do this as a documentation change.

My question is, was there originally a reason to have a different format from remark-custom-blocks?

I don't know for sure, but I can't think of a good reason why having a different format would be useful here.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's some nice docs. Thanks :)

I made one minor comment but otherwise this looks great 🎉

@@ -2,14 +2,27 @@

Adds custom blocks to `MarkdownRemark` using [remark-custom-blocks](https://github.com/zestedesavoir/zmarkdown/tree/master/packages/remark-custom-blocks).

Unlike
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Copy link
Contributor Author

@giraffesyo giraffesyo Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, had a train of thought there that went astray. I added a commit to fix this. Let me know if there should be any changes.

@giraffesyo
Copy link
Contributor Author

Thanks @m-allanson!

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @giraffesyo 👍

@m-allanson m-allanson merged commit 9c34da2 into gatsbyjs:master Jul 12, 2018
@giraffesyo giraffesyo deleted the hotfix/custom-blocks-use-classes branch July 12, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants