-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom blocks not using custom classes #6368
Fix custom blocks not using custom classes #6368
Conversation
Deploy preview for using-drupal ready! Built with commit a41db82 |
Deploy preview for gatsbygram ready! Built with commit a41db82 |
This looks good, thanks @giraffesyo. What do you think about changing the config format of |
@m-allanson If you pass the options as documented on the |
👍 Yeah let's do this as a documentation change.
I don't know for sure, but I can't think of a good reason why having a different format would be useful here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that's some nice docs. Thanks :)
I made one minor comment but otherwise this looks great 🎉
@@ -2,14 +2,27 @@ | |||
|
|||
Adds custom blocks to `MarkdownRemark` using [remark-custom-blocks](https://github.com/zestedesavoir/zmarkdown/tree/master/packages/remark-custom-blocks). | |||
|
|||
Unlike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, had a train of thought there that went astray. I added a commit to fix this. Let me know if there should be any changes.
Thanks @m-allanson! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @giraffesyo 👍
Fixes #6366