Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs content in preperation for v2 release #8172

Merged
merged 7 commits into from
Sep 17, 2018

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 14, 2018

checked any occurrence of beta, @next, #v2, prerelease

this needs review - especially section about updating/upgrading packages in migration guide

Closes #7976

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small change to the copy that'd be nice — I'll just make it. Ignore my other comments :-)

docs/docs/migrating-from-v1-to-v2.md Show resolved Hide resolved
@@ -930,26 +934,26 @@ Import graphql types from `gatsby/graphql` to prevent `Schema must contain uniqu

Here's a brief section on starting a new project with Gatsby v2 instead of upgrading an existing project.

_Start from scratch:_ If you're a _start from scratch_ kind of person, you can install the Gatsby beta and React like this: `npm install gatsby@next react react-dom`
_Start from scratch:_ If you're a _start from scratch_ kind of person, you can install the Gatsby and React like this: `npm install gatsby react react-dom`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "the" here needs removed you can install Gatsby and React like this:

@KyleAMathews KyleAMathews mentioned this pull request Sep 17, 2018
10 tasks
@KyleAMathews KyleAMathews merged commit 2766660 into gatsbyjs:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants