fix: use path prefix in navigate/replace/push calls #8289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do |
|
@pieh yup, it should! I originally had a variant where they didn't, but they do! I validated with gatsby-dev-cli. Basically the behavior is unchanged, we'll pass through
|
DSchau
commented
Sep 18, 2018
|
|
||
| describe('navigate', () => { | ||
| beforeEach(() => { | ||
| cy.visit(`/`) |
There was a problem hiding this comment.
As info, waitForRouteChange() wasn't working here. Will give it another shot in a bit just to validate I'm not crazy.
There was a problem hiding this comment.
was it timing out? I've tried some more involved stuff and didn't work for me today too but didn't dig into that yet
oorestisime
pushed a commit
to oorestisime/gatsby
that referenced
this pull request
Sep 28, 2018
…sbyjs#8289) * fix: prefix navigate calls with pathPrefix Fixes gatsbyjs#8155 * test: fix unit tests and add a few new ones * e2e: update integration tests * test: standardize on trailing slash * fix: ensure parsePath still works the way it used to with path * style: run eslint * fix: use waitForRouteChange API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior re: pathPrefix identified in #8155.
Essentially:
withPrefixhelper in all programmatic navigationLink