Skip to content

Commit

Permalink
block: allow blk_rq_map_kern to append to requests
Browse files Browse the repository at this point in the history
Use blk_rq_append_bio() internally instead of blk_rq_bio_prep()
so blk_rq_map_kern can be called multiple times, to map multiple
buffers.

This is in the effort to un-export blk_rq_append_bio()

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
James Bottomley authored and Jens Axboe committed May 19, 2009
1 parent b2858d7 commit 3a5a392
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions block/blk-map.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,16 @@ EXPORT_SYMBOL(blk_rq_unmap_user);
*
* Description:
* Data will be mapped directly if possible. Otherwise a bounce
* buffer is used.
* buffer is used. Can be called multple times to append multple
* buffers.
*/
int blk_rq_map_kern(struct request_queue *q, struct request *rq, void *kbuf,
unsigned int len, gfp_t gfp_mask)
{
int reading = rq_data_dir(rq) == READ;
int do_copy = 0;
struct bio *bio;
int ret;

if (len > (q->max_hw_sectors << 9))
return -EINVAL;
Expand All @@ -311,7 +313,13 @@ int blk_rq_map_kern(struct request_queue *q, struct request *rq, void *kbuf,
if (do_copy)
rq->cmd_flags |= REQ_COPY_USER;

blk_rq_bio_prep(q, rq, bio);
ret = blk_rq_append_bio(q, rq, bio);
if (unlikely(ret)) {
/* request is too big */
bio_put(bio);
return ret;
}

blk_queue_bounce(q, &rq->bio);
rq->buffer = NULL;
return 0;
Expand Down

0 comments on commit 3a5a392

Please sign in to comment.