Skip to content

Commit

Permalink
staging: rtl8192e: replace explicit NULL comparison
Browse files Browse the repository at this point in the history
Replace explicit NULL comparison with ! operator to
simplify code.

Found with Coccinelle script:
@@
expression ptr;
position p;
statement s0, s1;
@@

ptr@p =
\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
alloc_netdev\|dev_alloc_skb\)(...)
... when != ptr

if (
(
+ !
ptr
- == NULL
)
) s0 else s1

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gs0510 authored and gregkh committed Mar 6, 2017
1 parent 3337134 commit 5043bd3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/rtl8192e/rtl819x_BAProc.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
return NULL;
}
skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
if (skb == NULL)
if (!skb)
return NULL;

memset(skb->data, 0, sizeof(struct rtllib_hdr_3addr));
Expand Down Expand Up @@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
DelbaParamSet.field.TID = pBA->BaParamSet.field.TID;

skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
if (skb == NULL)
if (!skb)
return NULL;

skb_reserve(skb, ieee->tx_headroom);
Expand Down

0 comments on commit 5043bd3

Please sign in to comment.