Skip to content

Commit

Permalink
staging: lustre: Replace typedef with struct
Browse files Browse the repository at this point in the history
As per the Linux kernel coding style guidelines, using typedef for a
structure type is not recommended. Hence, occurences of typedefs have
been removed. To find the occurences of the structures grep was used
and no uses were found.

Coccinelle script:

@r1@
type T;
@@

typedef struct { ... } T;

@script:python c1@
T2;
T << r1.T;
@@
coccinelle.T2=T;

@@
type r1.T;
identifier c1.T2;
@@
-typedef
struct
+ T2
{ ... }
-T
;

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gs0510 authored and gregkh committed Mar 6, 2017
1 parent 22171e3 commit 69385ad
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/staging/lustre/lustre/include/lustre_eacl.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,17 @@
#include <linux/fs.h>
#include <linux/posix_acl_xattr.h>

typedef struct {
struct ext_acl_xattr_entry {
__u16 e_tag;
__u16 e_perm;
__u32 e_id;
__u32 e_stat;
} ext_acl_xattr_entry;
};

typedef struct {
__u32 a_count;
ext_acl_xattr_entry a_entries[0];
} ext_acl_xattr_header;
struct ext_acl_xattr_header {
__u32 a_count;
struct ext_acl_xattr_entry a_entries[0];
};

#define CFS_ACL_XATTR_SIZE(count, prefix) \
(sizeof(prefix ## _header) + (count) * sizeof(prefix ## _entry))
Expand Down

0 comments on commit 69385ad

Please sign in to comment.