Skip to content

Commit

Permalink
char: ipmi: eliminate misleading print info when being probed via ACPI
Browse files Browse the repository at this point in the history
When ipmi is probed via ACPI, the boot log shows

[   17.945139] ipmi_si IPI0001:00: probing via device tree
[   17.950369] ipmi_si IPI0001:00: ipmi_si: probing via ACPI
[   17.955795] ipmi_si IPI0001:00: [io  0x00e4-0x3fff] regsize 1 spacing 1 irq 0
[   17.962932] ipmi_si: Adding ACPI-specified bt state machine

which "ipmi_si IPI0001:00: probing via device tree" is misleading
with a ACPI HID "IPI0001" but probing via DT.

Eliminate this misleading print info by checking of_node is valid
or not before calling of_ipmi_probe().

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
  • Loading branch information
hanjun-guo authored and cminyard committed Sep 27, 2017
1 parent 9cd6681 commit 719c1b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/ipmi/ipmi_si_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2784,7 +2784,7 @@ static int acpi_ipmi_probe(struct platform_device *dev)

static int ipmi_probe(struct platform_device *dev)
{
if (of_ipmi_probe(dev) == 0)
if (dev->dev.of_node && of_ipmi_probe(dev) == 0)
return 0;

if (acpi_ipmi_probe(dev) == 0)
Expand Down

0 comments on commit 719c1b3

Please sign in to comment.