Skip to content

Commit

Permalink
selinux: replace obsolete NLMSG_* with type safe nlmsg_*
Browse files Browse the repository at this point in the history
Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
honkiko authored and davem330 committed Mar 28, 2013
1 parent 9419121 commit 7795498
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions security/selinux/hooks.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
#include <linux/bitops.h>
#include <linux/interrupt.h>
#include <linux/netdevice.h> /* for network interface checks */
#include <linux/netlink.h>
#include <net/netlink.h>
#include <linux/tcp.h>
#include <linux/udp.h>
#include <linux/dccp.h>
Expand Down Expand Up @@ -4475,7 +4475,7 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb)
struct nlmsghdr *nlh;
struct sk_security_struct *sksec = sk->sk_security;

if (skb->len < NLMSG_SPACE(0)) {
if (skb->len < NLMSG_HDRLEN) {
err = -EINVAL;
goto out;
}
Expand Down
3 changes: 1 addition & 2 deletions security/selinux/netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include <linux/kernel.h>
#include <linux/export.h>
#include <linux/skbuff.h>
#include <linux/netlink.h>
#include <linux/selinux_netlink.h>
#include <net/net_namespace.h>
#include <net/netlink.h>
Expand Down Expand Up @@ -77,7 +76,7 @@ static void selnl_notify(int msgtype, void *data)

len = selnl_msglen(msgtype);

skb = alloc_skb(NLMSG_SPACE(len), GFP_USER);
skb = nlmsg_new(len, GFP_USER);
if (!skb)
goto oom;

Expand Down

0 comments on commit 7795498

Please sign in to comment.