Skip to content

Commit

Permalink
serial: 8250_early: Remove setup_early_serial8250_console()
Browse files Browse the repository at this point in the history
setup_earlycon() will now match and register the desired earlycon
from the param string (as if 'earlycon=...' had been set on the
command line). Use setup_earlycon() from existing arch call sites
which start an earlycon directly.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
peterhurley authored and gregkh committed Mar 26, 2015
1 parent 470ca0d commit df519e7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions arch/mips/mti-malta/malta-init.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include <linux/init.h>
#include <linux/string.h>
#include <linux/kernel.h>
#include <linux/serial_8250.h>
#include <linux/serial_core.h>

#include <asm/cacheflush.h>
#include <asm/smp-ops.h>
Expand Down Expand Up @@ -75,7 +75,7 @@ static void __init console_config(void)
if ((strstr(fw_getcmdline(), "earlycon=")) == NULL) {
sprintf(console_string, "uart8250,io,0x3f8,%d%c%c", baud,
parity, bits);
setup_early_serial8250_console(console_string);
setup_earlycon(console_string);
}

if ((strstr(fw_getcmdline(), "console=")) == NULL) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/firmware/pcdp.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <linux/console.h>
#include <linux/efi.h>
#include <linux/serial.h>
#include <linux/serial_8250.h>
#include <linux/serial_core.h>
#include <asm/vga.h>
#include "pcdp.h"

Expand Down Expand Up @@ -43,7 +43,7 @@ setup_serial_console(struct pcdp_uart *uart)
}

add_preferred_console("uart", 8250, &options[9]);
return setup_early_serial8250_console(options);
return setup_earlycon(options);
#else
return -ENODEV;
#endif
Expand Down
5 changes: 0 additions & 5 deletions drivers/tty/serial/8250/8250_early.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,3 @@ static int __init early_serial8250_setup(struct earlycon_device *device,
}
EARLYCON_DECLARE(uart8250, early_serial8250_setup);
EARLYCON_DECLARE(uart, early_serial8250_setup);

int __init setup_early_serial8250_console(char *cmdline)
{
return setup_earlycon(cmdline);
}
1 change: 0 additions & 1 deletion include/linux/serial_8250.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ extern int early_serial_setup(struct uart_port *port);

extern unsigned int serial8250_early_in(struct uart_port *port, int offset);
extern void serial8250_early_out(struct uart_port *port, int offset, int value);
extern int setup_early_serial8250_console(char *cmdline);
extern void serial8250_do_set_termios(struct uart_port *port,
struct ktermios *termios, struct ktermios *old);
extern int serial8250_do_startup(struct uart_port *port);
Expand Down

0 comments on commit df519e7

Please sign in to comment.