Skip to content

Commit

Permalink
Merge branch 'hotfix/update-deps'
Browse files Browse the repository at this point in the history
  • Loading branch information
gordonwoodhull committed Feb 27, 2015
2 parents b61dc54 + 20fbb28 commit ca211e4
Show file tree
Hide file tree
Showing 4 changed files with 144 additions and 96 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"grunt-contrib-concat": "~0.5.0",
"grunt-contrib-connect": "~0.9.0",
"grunt-contrib-copy": "~0.7.0",
"grunt-contrib-jasmine": "~0.8.1",
"grunt-contrib-jasmine": "~0.8.2",
"grunt-contrib-jshint": "~0.10.0",
"grunt-contrib-uglify": "~0.7.0",
"grunt-contrib-watch": "~0.6.1",
Expand Down
4 changes: 3 additions & 1 deletion spec/bar-chart-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,9 @@ describe('dc.barChart', function() {

it("should not round the brush", function () {
jasmine.clock().tick(100);
expect(chart.filter()).toEqual([makeDate(2012, 6, 1), makeDate(2012, 7, 15)]);
var filter = chart.filter();
delete filter.isFiltered;
expect(filter).toEqual([makeDate(2012, 6, 1), makeDate(2012, 7, 15)]);
});
});

Expand Down
14 changes: 11 additions & 3 deletions spec/coordinate-grid-chart-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,9 @@ describe('dc.coordinateGridChart', function() {
});

it("should update chart filter to match new x domain", function () {
expect(chart.filter()).toEqual(chart.x().domain());
var filter = chart.filter();
delete filter.isFiltered;
expect(filter).toEqual(chart.x().domain());
});

it("should be rescaled", function () {
Expand Down Expand Up @@ -822,7 +824,10 @@ describe('dc.coordinateGridChart', function() {
rangeChart.brush().extent(selectedRange);
rangeChart.brush().event(rangeChart.g());
jasmine.clock().tick(100);
expect(chart.focus).toHaveBeenCalledWith(selectedRange);
// expect(chart.focus).toHaveBeenCalledWith(selectedRange);
var focus = chart.focus.calls.argsFor(0)[0];
delete focus.isFiltered;
expect(focus).toEqual(selectedRange);
});

it("should zoom the focus chart back out when range chart is un-brushed", function () {
Expand All @@ -839,7 +844,10 @@ describe('dc.coordinateGridChart', function() {
it("should update the range chart brush to match zoomed domain of focus chart", function () {
spyOn(rangeChart, "replaceFilter");
chart.focus(selectedRange);
expect(rangeChart.replaceFilter).toHaveBeenCalledWith(selectedRange);
// expect(rangeChart.replaceFilter).toHaveBeenCalledWith(selectedRange);
var replaceFilter = rangeChart.replaceFilter.calls.argsFor(0)[0];
delete replaceFilter.isFiltered;
expect(replaceFilter).toEqual(selectedRange);
});
});

Expand Down
Loading

0 comments on commit ca211e4

Please sign in to comment.