-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support backward-cpp #2
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
08d7faa
New custom file for Bionic
j-rivero 58f1a5d
Do not release for Sid
j-rivero 78a7028
Miss backward-cpp build-dep
j-rivero 4c299d0
Need custom control for Bionic
j-rivero e287aa6
Control Bionic without backward
j-rivero 2e6dc66
Include libignition-tools-backward library in main package
j-rivero 1f584c5
Refine libraries in -dev package
j-rivero 2bd9385
1.5.0~pre1 for Focal
j-rivero 666aee2
Revert changelog entry
j-rivero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| Source: ignition-tools | ||
| Standards-Version: 3.9.8 | ||
| Maintainer: Jose Luis Rivero <jrivero@osrfoundation.org> | ||
| Section: science | ||
| Priority: optional | ||
| Build-Depends: debhelper (>= 9~), | ||
| gem2deb, | ||
| cmake, | ||
| pkg-config | ||
| XS-Ruby-Versions: all | ||
| Vcs-Browser: https://bitbucket.org/ignitionrobotics/ign-tools-release | ||
| Vcs-Hg: https://bitbucket.org/ignitionrobotics/ign-tools-release | ||
| Homepage: http://ignitionrobotics.org/ | ||
|
|
||
| Package: ignition-tools | ||
| Architecture: any | ||
| Section: libs | ||
| Pre-Depends: ${misc:Pre-Depends} | ||
| XB-Ruby-Versions: ${ruby:Versions} | ||
| Depends: ruby | ruby-interpreter, | ||
| ${misc:Depends} | ||
| Multi-Arch: same | ||
| Description: Ignition entry point for using all the suite of ignition tools | ||
| Ignition tools is a component in the ignition framework, a set of libraries | ||
| designed to rapidly develop robot applications. | ||
|
|
||
| Package: libignition-tools-dev | ||
| Architecture: any | ||
| Section: libdevel | ||
| Depends: cmake, | ||
| ignition-tools, | ||
| ${misc:Depends} | ||
| Multi-Arch: same | ||
| Description: CMake/Pkgconfig Support for rest of the suite of ignition tools | ||
| Ignition tools is a component in the ignition framework, a set of libraries | ||
| designed to rapidly develop robot applications. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/usr/bin/make -f | ||
|
|
||
|
|
||
| .PHONY: override_dh_auto_configure | ||
|
|
||
| override_dh_auto_configure: | ||
| # backward-cpp not in Bionic | ||
| dh_auto_configure -- \ | ||
| -DUSE_SYSTEM_BACKWARDCPP=OFF \ | ||
| -DCMAKE_BUILD_TYPE=RelWithDebInfo | ||
| %: | ||
| dh $@ --buildsystem=cmake --with ruby |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| usr/bin/* | ||
| usr/lib/*/libignition-tools-backward.so |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| usr/lib/ | ||
| /usr/lib/*/pkgconfig/ | ||
| /usr/lib/*/cmake/ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kinda goes against the undocumented rule we have against adding dependencies in minor releases. In this case I guess the alternative would be vendoring, which I don't think is recommended.
Do you think the addition of this dependency could negatively impact downstream users? Note that
ign-tools1is a dependency of pretty much all simulators we maintain right now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is a bit special since the dependency is only a build-dep, headers go into the build and no more is needed, if I understand the scenario correctly. If this is right, we are not modifying the dependency chain for consumers of the library just altering the build conditions providing the necessary source code for platforms without backwards-cpp. Seems safe to me to make an exception to the rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I agree that it's ok if it's only needed while building. To be honest, I haven't looked into how it's all hooked up. I just noticed some failing downstream CI that couldn't find backward though.