Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved coverage remotery #467

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 26, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 Code coverage

Summary

Improved coverage remotery

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 26, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #467 (9e8616e) into ign-common3 (1157051) will increase coverage by 1.01%.
The diff coverage is n/a.

❗ Current head 9e8616e differs from pull request most recent head ef56b13. Consider uploading reports for the commit ef56b13 to get more accurate results

@@               Coverage Diff               @@
##           ign-common3     #467      +/-   ##
===============================================
+ Coverage        81.65%   82.66%   +1.01%     
===============================================
  Files               72       72              
  Lines             9244     9244              
===============================================
+ Hits              7548     7642      +94     
+ Misses            1696     1602      -94     
Impacted Files Coverage Δ
profiler/src/RemoteryProfilerImpl.cc 84.13% <0.00%> (+64.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 26, 2022

@osrf-jenkins run tests please!

@ahcorde ahcorde merged commit 3771b0d into ign-common3 Oct 26, 2022
@ahcorde ahcorde deleted the ahcorde/3/coverage_remotery branch October 26, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants