-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new function in MeshManager to merge all submeshes of a mesh into one #588
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 80.47% 80.54% +0.06%
==========================================
Files 80 80
Lines 13542 13573 +31
==========================================
+ Hits 10898 10932 +34
+ Misses 2644 2641 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change, but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @ahcorde's comment addressed
Signed-off-by: Ian Chen <ichen@openrobotics.org>
… one (#588) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org>
… one (#588) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org>
* Various Bazel adjustments for linting (#582) Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Prepare for 5.5.1 (#586) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Adds new function in MeshManager for performing convex decomposition (#585) Signed-off-by: Ian Chen <ichen@openrobotics.org> * Add new function in MeshManager to merge all submeshes of a mesh into one (#588) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org> * Fix bazel build (#592) Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com> * Remove pessimizing move (#593) Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Shameek Ganguly <shameekarcanesphinx@gmail.com> --------- Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: shameekganguly <shameekarcanesphinx@gmail.com>
🎉 New feature
Summary
Add a new static function in MeshManager to merge all submeshes into one. The new function returns a new mesh with a single combined submesh
Note I also made the
ConvexDecomposition
function that I added in #585 static as it does not need to be a member function.Test it
Added a test that merges two submehes and checked that all its vertices, normals, indices, and texcoords are correct.
Run the
UNIT_MeshManager_TEST
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.