Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage ignore file #179

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

New feature

Part of gz-sim#1575

Summary

Add coverage.ignore.in to ignore vendor code in code coverage report. See gz-cmake#279 for detail.

Increase the coverage rate from ~30% -> ~56%

20220719164430

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added the needs upstream release Blocked by a release of an upstream library label Jul 19, 2022
@AzulRadio AzulRadio changed the base branch from ign-launch5 to ign-launch2 July 19, 2022 21:52
@AzulRadio AzulRadio added the QA Quality assurance. label Jul 19, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #179 (f00740c) into ign-launch2 (0f6edef) will increase coverage by 26.50%.
The diff coverage is n/a.

❗ Current head f00740c differs from pull request most recent head 6fc93b1. Consider uploading reports for the commit 6fc93b1 to get more accurate results

@@               Coverage Diff                @@
##           ign-launch2     #179       +/-   ##
================================================
+ Coverage        30.24%   56.74%   +26.50%     
================================================
  Files                3        2        -1     
  Lines              734      326      -408     
================================================
- Hits               222      185       -37     
+ Misses             512      141      -371     
Impacted Files Coverage Δ
src/vendor/backward.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6edef...6fc93b1. Read the comment docs.

@chapulina chapulina requested a review from jennuine July 20, 2022 15:00
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added 🏰 citadel Ignition Citadel and removed 🏯 fortress Ignition Fortress needs upstream release Blocked by a release of an upstream library labels Jul 25, 2022
@AzulRadio AzulRadio marked this pull request as ready for review July 25, 2022 22:24
@AzulRadio AzulRadio requested a review from nkoenig as a code owner July 25, 2022 22:24
@jennuine jennuine mentioned this pull request Jul 25, 2022
5 tasks
Signed-off-by: youhy <haoyuan2019@outlook.com>
coverage.ignore.in Outdated Show resolved Hide resolved
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio merged commit 5bc7537 into ign-launch2 Jul 27, 2022
@AzulRadio AzulRadio deleted the azulradio/codecover_ignore branch July 27, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants