Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run to time #108

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Run to time #108

merged 1 commit into from
Dec 23, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 9, 2020

Adds a run-to-time field to the WorldControl message.

@nkoenig nkoenig requested a review from caguero as a code owner December 9, 2020 19:56
@nkoenig nkoenig mentioned this pull request Dec 9, 2020
Merged
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #108 (65364c5) into main (b45b12e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           7        7           
  Lines         818      818           
=======================================
  Hits          692      692           
  Misses        126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45b12e...1d33f3c. Read the comment docs.

@chapulina chapulina mentioned this pull request Dec 10, 2020
Closed
chapulina
chapulina approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nkoenig , mind signing all commits?

@nkoenig @chapulina
Added run_to_sim_time to world_control message.
1d33f3c 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@chapulina
Copy link
Contributor

I rebased and fixed DCO, merging.

@chapulina chapulina merged commit 5a0cec0 into main Dec 23, 2020
@chapulina chapulina deleted the run_to_time branch December 23, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkoenig @chapulina @caguero