Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations, and a now invalid todo #112

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 14, 2020

Removed old deprecations and a todo that has been resolved.

Signed-off-by: Nate Koenig nate@openrobotics.org

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #112 (cfd5c90) into main (2a438bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           7        7           
  Lines         818      818           
=======================================
  Hits          692      692           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a438bf...cfd5c90. Read the comment docs.

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we mention the removals in the Migration.md?

caguero and others added 3 commits December 21, 2020 20:34
@nkoenig
Copy link
Contributor Author

nkoenig commented Dec 22, 2020

Looks good to me. Should we mention the removals in the Migration.md?

Added notes in cfd5c90

@nkoenig nkoenig merged commit 987d226 into main Dec 22, 2020
@nkoenig nkoenig deleted the v7_remove_deprecations branch December 22, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants