Adding additional fields to the camera sensor message #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 7 7
Lines 855 855
=======================================
Hits 723 723
Misses 132 132 Continue to review full report at Codecov.
|
chapulina
changed the title
chapulina
added
the
Breaking change
added 2 commits
July 26, 2022 08:39
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 84.96% 84.96%
=======================================
Files 10 10
Lines 1024 1024
=======================================
Hits 870 870
Misses 154 154 Continue to review full report at Codecov.
|
chapulina
suggested changes
Jul 29, 2022
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
…n-msgs into camera_sensor_update
chapulina
suggested changes
Jul 29, 2022
chapulina
reviewed
Jul 29, 2022
chapulina
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig nate@openrobotics.org
🎉 New feature
Summary
Adding fields to the camera sensor message so that it matches the fields in SDF.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge