Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker: support different colors per point #202

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Nov 20, 2021

🎉 New feature

Summary

The goal is to be able to display points with different colors. Right now, that's possible using one point per Marker message inside a Marker_V, but that hurts performance because there's a lot of duplication on each nested message.

The approach taken here is similar to the marker message on RViz.

Points only really need one color, they currently only use diffuse from the material field. I decided to go with a full Material message instead of just a plain color because we may want to use this field for other things like triangles in the future.

The branch is currently on ign-msgs8 while I work on the implementation, but the goal is to merge this into main after gazebo-tooling/release-tools#554. Rebased onto main.

Test it

There's a demo on ign-gui:

pts_color

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added enhancement New feature or request 🌱 garden Ignition Garden labels Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #202 (255ed82) into main (3074522) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files           7        7           
  Lines         855      855           
=======================================
  Hits          723      723           
  Misses        132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3074522...255ed82. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina marked this pull request as ready for review December 6, 2021 23:02
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@chapulina chapulina merged commit eb21867 into main Dec 8, 2021
@chapulina chapulina deleted the chapulina/marker_point_color branch December 8, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants