Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition -> Gazebo #273

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Ignition -> Gazebo #273

merged 3 commits into from
Jul 15, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Jul 14, 2022

🦟 Bug fix

Part of:

Summary

Updated links and naming

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine requested a review from chapulina July 14, 2022 22:57
@jennuine jennuine requested a review from caguero as a code owner July 14, 2022 22:57
@jennuine jennuine self-assigned this Jul 14, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 14, 2022
@chapulina chapulina added tests Broken or missing tests / testing infra QA Quality assurance. labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #273 (fd427eb) into ign-msgs5 (97ea6f5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-msgs5     #273   +/-   ##
==========================================
  Coverage      85.27%   85.27%           
==========================================
  Files              9        9           
  Lines            903      903           
==========================================
  Hits             770      770           
  Misses           133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ea6f5...fd427eb. Read the comment docs.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine changed the title Update codecov badge Ignition -> Gazebo Jul 14, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

README.md Outdated Show resolved Hide resolved
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@chapulina chapulina merged commit 1c6da4d into ign-msgs5 Jul 15, 2022
@chapulina chapulina deleted the jennuine/codecov_badge branch July 15, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants