Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACTOR and WORLD types to entity #275

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 15, 2022

🎉 New feature

Summary

I noticed that we were missing a couple of entity types in the entity message. Looking at the generated C++ code, I think this change is backwards compatible. Let's see what the ABI checker has to say.

Test it

These are used in this PR:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 15, 2022
@chapulina chapulina requested a review from caguero as a code owner July 15, 2022 15:24
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 15, 2022
@mjcarroll
Copy link
Contributor

LGTM modulo ABI (Should be good by my recollection)

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #275 (b40c12c) into ign-msgs5 (97ea6f5) will not change coverage.
The diff coverage is n/a.

❗ Current head b40c12c differs from pull request most recent head 9f263c5. Consider uploading reports for the commit 9f263c5 to get more accurate results

@@            Coverage Diff             @@
##           ign-msgs5     #275   +/-   ##
==========================================
  Coverage      85.27%   85.27%           
==========================================
  Files              9        9           
  Lines            903      903           
==========================================
  Hits             770      770           
  Misses           133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ea6f5...9f263c5. Read the comment docs.

@chapulina chapulina merged commit ef7a615 into ign-msgs5 Jul 15, 2022
@chapulina chapulina deleted the chapulina/5/actor_entity branch July 15, 2022 15:46
@Kakcalu13
Copy link

Sorry for being late but how do we use this in ign commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants