Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moon and custom surfaces in spherical coords msg #279

Merged
merged 7 commits into from
Jul 21, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Jul 19, 2022

Signed-off-by: Aditya aditya050995@gmail.com

🎉 New feature

Summary

Part of the feature : Supporting lunar DEMs and custom surfaces in spherical coordinates. Adds new fields surface_axis_equatorial and surface_axis_polar to spherical coordinates proto msg, allows new enums MOON_SCS and CUSTOM_SURFACE.

Test it

Added test cases.

Depends on

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

…inition

Signed-off-by: Aditya <aditya050995@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 19, 2022
@adityapande-1995 adityapande-1995 changed the title Add moon and custom surfaces to conversion functions, updated msg def… Allow moon and custom surfaces in spherical coords msg Jul 19, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #279 (598d30d) into main (783d087) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   85.44%   85.59%   +0.14%     
==========================================
  Files          10       10              
  Lines         962      972      +10     
==========================================
+ Hits          822      832      +10     
  Misses        140      140              
Impacted Files Coverage Δ
src/Utility.cc 82.56% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783d087...598d30d. Read the comment docs.

Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
src/Utility_TEST.cc Show resolved Hide resolved
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995 adityapande-1995 merged commit 0a09d3d into main Jul 21, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/lunar_and_custom_dems branch July 21, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants