-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new discovery types #322
Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 95.41% 95.43% +0.01%
==========================================
Files 10 10
Lines 1026 1030 +4
==========================================
+ Hits 979 983 +4
Misses 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I know that in a regular C++ class its allowed to append a new enumeration to an existing enum without breaking ABI but does anybody know if it's safe to do it inside a protobuf? I assumed that any change in an existing message would break it but if that's not the case I could retarget it to |
🎉 New feature
Summary
This pull request adds some new discovery types to the discovery message.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.