Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate find_package(Python3) call #420

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebosim/gz-sim#2249.

Summary

There is already a find_package(Python3) call on line 124 next to the other python logic, so remove the earlier duplicate call, as there is nothing else that needs it that early.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daeb089) 97.67% compared to head (05f5139) 97.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #420   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit 2b66954 into gz-msgs10 Jan 24, 2024
13 checks passed
@scpeters scpeters deleted the scpeters/fix_find_python branch January 24, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants