Add CMake options to support cross-compilation #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two CMake options: * INSTALL_IGN_MSGS_GEN_EXECUTABLE if this option is enabled, the ign_msgs_gen protobuf executable plugin is also installed, so that this option can be enabled in host builds to permit cross-compilation builds to use it to generate the messages. As this executable is not side by side installable with other ignition-msgs installations with different major versions and is an advanced option meant just for packaging, by default it is set to OFF. * IGN_MSGS_GEN_EXECUTABLE: this string variable can be set to have ign-msgs use a ign_msgs_gen executable plugin that was not build by the project, to enable cross-compilation scenarios. Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
traversaro
force-pushed
the
support-crosscompilation
branch
from
421d7cd
to
8d37356
Compare
|
Related vcpkg PR: microsoft/vcpkg#11538 . |
|
Hi @traversaro, this is great! Could you provide a simple step-by-step example/instructions that show how to take advantage of this feature please? It doesn't have to be in the code, a comment with the instructions is enough. |
|
Hi @iche033, do you mean as a comment in the CMake code or somewhere else? |
In the description or in the CMake code. |
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
traversaro
force-pushed
the
support-crosscompilation
branch
from
a7c2c1b
to
3226f99
Compare
|
I added some docs as CMake comments in 3226f99 . |
Thanks! |
caguero
approved these changes
Jun 1, 2020
This was referenced Jul 9, 2021
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two CMake options:
INSTALL_IGN_MSGS_GEN_EXECUTABLEif this option is enabled, the ign_msgs_gen protobuf executable plugin is also installed, so that this option can be enabled in host builds to permit cross-compilation builds to use it to generate the messages. As this executable is not side by side installable with other ignition-msgs installations with different major versions and this is an advanced option meant just for packaging, by default it is set to OFF.IGN_MSGS_GEN_EXECUTABLE: this string variable can be set to have ign-msgs use a ign_msgs_gen executable plugin that was not build by the project, to enable cross-compilation scenarios.Fix #34 .