Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert functions between duration and ignition::time #85

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 14, 2020

As discussed in the PR gazebosim/gz-sensors#41 (comment) makes sense to use duration instead of time_point, This function will convert secs and nanoseconds to std::chrono::steady_clock::duration

This PR is part of this issue gazebosim/gz-common#61.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the beta Targeting beta release of upcoming collection label Sep 14, 2020
@ahcorde ahcorde self-assigned this Sep 14, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #85 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   85.83%   85.85%   +0.01%     
==========================================
  Files           7        7              
  Lines         805      806       +1     
==========================================
+ Hits          691      692       +1     
  Misses        114      114              
Impacted Files Coverage Δ
src/Utility.cc 83.73% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebac094...85d4c26. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could keep the old functions, but since this is ready to go I don't think it needs to change. I'd just ask that the style comment below be fixed before merging 😉

src/Utility_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina chapulina merged commit 3f972db into master Sep 14, 2020
@chapulina chapulina deleted the ahcorde/convert/duration branch September 14, 2020 21:06
@chapulina chapulina mentioned this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants